[2.32] develop: fill in output paths for shell derivation#14738
Closed
Mic92 wants to merge 1 commit intoNixOS:2.32-maintenancefrom
Closed
[2.32] develop: fill in output paths for shell derivation#14738Mic92 wants to merge 1 commit intoNixOS:2.32-maintenancefrom
Mic92 wants to merge 1 commit intoNixOS:2.32-maintenancefrom
Conversation
Contributor
|
It looks like master is in the wrong here then and it shouldn't be validating that stuff in the first place. We should fix that before 2.33 |
Newer nix daemons validate that derivations have their deferred outputs filled in. Fill in InputAddressed output paths for derivations that have Regular hash kind, while leaving CA floating derivations alone. This matches the behavior of master's fillInOutputPaths(). Fixes compatibility with nix daemon >= 2.33.
Mic92
force-pushed
the
backport-ca-develop-fix
branch
from
028b75e to
f9b6222
Compare
Mic92
changed the title
Member
Author
You can fight this out with John :) It happens if you have ca-derivations enabled and use nix develop of nix 2.31/2.32 with master for the nix-daemon. |
Member
Author
|
@xokdvium this is what I applied on my branch: Mic92@c12060a Also opened as a PR: #14739 |
Member
Author
|
I guess we do #14739 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer nix daemons validate that derivations have their deferred outputs filled in. Fill in InputAddressed output paths for derivations that have Regular hash kind, while leaving CA floating derivations alone.
This matches the behavior of master's fillInOutputPaths().
Fixes compatibility with nix daemon >= 2.33.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.